Secure fix missing para dbmodnet#4050
Conversation
Signed-off-by: Martin Povišer <povik@cutebit.org>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
|
designs/asap7/swerv_wrapper/ actually shows [INFO] finish__timing__setup__tns pass test: -46693.1 >= -47000 so it is not as catastrophic |
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
openroad-ci
force-pushed
the
secure-fix_missing_para_dbmodnet
branch
from
d6b6f0f to
ba99381
Compare
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
| }, | ||
| "finish__timing__setup__tns": { | ||
| "value": -320.0, | ||
| "value": -47000.0, |
There was a problem hiding this comment.
I am not sure why this number oscillates so much- yesterday baseline was -46993 and today it was somehow regoldened to -320 and my code makes it back to -47000. This is also the test that gets affected by my change- with correct para now, it fallsback to the PRIMA dcalc path and - without my isExternal fix, it would have crashed in PRIMA. So this testcase is really stress testing my change
There was a problem hiding this comment.
It seems like the -320 value comes from PR one month ago. In any case I would expect your change to degrade (i.e. fix the reporting on) designs with hierarchy enabled, which swerv_wrapper seems to be one of.
There was a problem hiding this comment.
weird. yesterday I saw it -46993 in my local run.
"finish__timing__setup__ws": -239.109,
"finish__timing__setup__tns": -46693.1,
I wonder if this is exposing an issue in PRIMA delay calc now.. witherways, orthogonal..
4 participants
This PR needs metric change due to now vieweing parasitics correctly on modnets. Corresponds to this PR in OpenROAD The-OpenROAD-Project/OpenROAD#9745
CI Could not Update Rules
[ERROR] sky130hd/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/microwatt: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/riscv32i: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/aes: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/gcd: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/ibex: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/riscv32i: No metrics found, please check the latest CI build for issues.
CI Could not Update Rules
[ERROR] sky130hd/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/microwatt: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/riscv32i: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/aes: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/gcd: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/ibex: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/riscv32i: No metrics found, please check the latest CI build for issues.
Updated Rules
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/swerv_wrapper/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/swerv/rules-base.json updates:
designs/sky130hd/gcd/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:
Messages from CI
[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.
Updated Rules
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/swerv_wrapper/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/swerv/rules-base.json updates:
designs/nangate45/swerv_wrapper/rules-base.json updates:
designs/sky130hd/gcd/rules-base.json updates:
[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:
designs/sky130hs/ibex/rules-base.json updates:
Messages from CI
[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.